Fix/typescript bindings #1066
Merged
Fix/typescript bindings #1066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willemneal
approved these changes
Nov 2, 2023
elizabethengelman
force-pushed
the
fix/typescript-bindings
branch
from
60bd6ee
to
6f62f7d
Compare
willemneal
force-pushed
the
fix/typescript-bindings
branch
from
6f62f7d
to
502629e
Compare
chadoh
pushed a commit
to AhaLabs/stellar-cli
that referenced
this pull request
Nov 7, 2023
* Use the default freight-api export * Update soroban-client to 1.0.0-beta.3 * Update error handling in invoke to conform to soroban-client beta.3
chadoh
pushed a commit
that referenced
this pull request
Nov 8, 2023
* Use the default freight-api export * Update soroban-client to 1.0.0-beta.3 * Update error handling in invoke to conform to soroban-client beta.3 (cherry picked from commit e357ccb)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
@stellar/freighter-apiimport to use thedefaultobject if there is no wallet connected yet1.0.0-beta.3for the cli typescript bindings generationWhy
update the
@stellar/freighter-apiimport to use thedefault:Before this change, I was seeing an error when trying to use the generated bindings in the Getting Started demo app when a wallet isn't connected yet:
error wallet.isConnected is not a function@stellar/freighter-apireturns a null prototype with a default that has the expected methods,isConnected, etc. This should be sufficient for view calls, so this change just uses thedefaultuntil later in the invoke method, when an account is needed (for change calls).update the soroban-client version to
1.0.0-beta.3for the cli typescript bindings generation: the one update that seemed necessary to make this upgrade work was to change theerrorResultXdrfromsendTransactionresult toerrorResult.Known limitations
N/A